Kolla-Ansible/Kayobe version enforcement #1551
Conversation
|
Skipping the linter as I don't think it's possible to use |
|
Requires pip 24.0 or newer. (precheck added in 88dba74) |
| fail_msg: | | ||
| Pip must be 24.0 or newer to run this check. Upgrade pip by running | ||
| pip install -U pip and reinstall Kayobe by running: | ||
| pip install --force-reinstall -r {{ requirements_path }} |
There was a problem hiding this comment.
Note the order here must be observed as Kayobe installed on an older verison of pip will still show the incorrect version output in pip freeze, breaking the check.
|
Out of my curiosity - why are we doing that here jnstead in the Kayobe python CLI? |
This is more of a workaround for Kayobe/Kolla CLI version returning a different value from our downstream tagging, which don't follow pbr versioning. See upstream bug https://bugs.launchpad.net/kayobe/+bug/2101051 |
assumptionsandg
changed the title
| executable: /usr/bin/bash | ||
| register: kayobe_git_commit | ||
|
|
||
| - name: Clone Kayobe |
There was a problem hiding this comment.
I wonder if instead of doing all this manually, could you use:
pip install . --dry-run --report /tmp/test.json
Which i think will tell you the new commit of kayobe it would install.
There was a problem hiding this comment.
I'm not sure if this approach will work here, as we're cloning Kayobe to get the commit that matches up with the currently installed tag from the git SHA outputted in the venv, rather than the newest commit from Kayobe.
There was a problem hiding this comment.
So just to clarify, I was suggesting doing a dry run pip install of kayobe-config. That would work with any repo specified in requirements.txt, whereas this solution has some custom parsing of that and is hardcoded to:
- name: Clone Kayobe
ansible.builtin.git:
repo: https://github.com/stackhpc/kayobe.git
dest: /tmp/kayobe-git
version: stackhpc/{{ openstack_release }}
But was just a thought and can accept it might not do what you want.
assumptionsandg
force-pushed
the
check-kayobe-version
branch
from
188ea15 to
d1136a0
Compare
No description provided.